[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/5] target-i386: add PCLMULQDQ and AES-NI instr
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-devel] [PATCH 0/5] target-i386: add PCLMULQDQ and AES-NI instructions |
Date: |
Sat, 30 Mar 2013 08:44:38 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sat, Mar 30, 2013 at 03:16:29AM +0100, Aurelien Jarno wrote:
> This patch series adds the PCLMULQDQ and AES-NI instructions to the x86
> emulation. Along with the SSE4.1 and SSE4.2 series, this brings the
> instructions emulation to the level of a Westmere CPU.
>
> It has been tested with the valgrind testsuite and with the kernel
> autotest.
>
> Changes v1 -> v2:
> - Patch 3: Declare all constant tables as static
>
> Changes v2 -> v3:
> - Use constant tables from aes.c.
> - Fix AES instructions when source and destination registers are the
> same.
All patches look good to me, thanks.
Reviewed-by: Edgar E. Iglesias <address@hidden>
>
> Aurelien Jarno (5):
> target-i386: add pclmulqdq instruction
> target-i386: enable PCLMULQDQ on Westmere CPU
> aes: move aes.h from include/block to include/qemu
> aes: make Td[0-5] and Te[0-5] tables non static
> target-i386: add AES-NI instructions
>
> block/qcow.c | 2 +-
> block/qcow2.c | 2 +-
> block/qcow2.h | 2 +-
> include/block/aes.h | 26 ---
> include/qemu/aes.h | 45 ++++
> target-i386/cpu.c | 19 +-
> target-i386/fpu_helper.c | 1 +
> target-i386/ops_sse.h | 111 +++++++++
> target-i386/ops_sse_header.h | 11 +
> target-i386/translate.c | 10 +
> util/aes.c | 506
> +++++++++++++++++++++---------------------
> 11 files changed, 443 insertions(+), 292 deletions(-)
> delete mode 100644 include/block/aes.h
> create mode 100644 include/qemu/aes.h
>
> --
> 1.7.10.4
>
>
- [Qemu-devel] [PATCH 0/5] target-i386: add PCLMULQDQ and AES-NI instructions, Aurelien Jarno, 2013/03/29
- [Qemu-devel] [PATCH 1/5] target-i386: add pclmulqdq instruction, Aurelien Jarno, 2013/03/29
- [Qemu-devel] [PATCH 2/5] target-i386: enable PCLMULQDQ on Westmere CPU, Aurelien Jarno, 2013/03/29
- [Qemu-devel] [PATCH 3/5] aes: move aes.h from include/block to include/qemu, Aurelien Jarno, 2013/03/29
- [Qemu-devel] [PATCH 5/5] target-i386: add AES-NI instructions, Aurelien Jarno, 2013/03/29
- [Qemu-devel] [PATCH 4/5] aes: make Td[0-5] and Te[0-5] tables non static, Aurelien Jarno, 2013/03/29
- Re: [Qemu-devel] [PATCH 0/5] target-i386: add PCLMULQDQ and AES-NI instructions,
Edgar E. Iglesias <=
- Re: [Qemu-devel] [PATCH 0/5] target-i386: add PCLMULQDQ and AES-NI instructions, Richard Henderson, 2013/03/30