Re: [Qemu-devel] [PATCH]: Fix conditional compilation for OpenBSD

[Peter Maydell]

On 31 March 2013 00:32, Michael W. Bombardieri <address@hidden> wrote:
> This morning I tried building Qemu 1.4.0 on my
> Lenovo ThinkPad T61 running OpenBSD/i386 5.1.
> The thread code didn't build due to a missing
> library function. Looking at the code, #if
> statements for NetBSD should also be followed
> for OpenBSD. Using the following patch I was
> able to build Qemu using clang 3.0 (gcc 4.2.1
> ran out of memory). Please consider committing
> this patch.

Hi Michael; thanks for the patch. However I think we should
fix this by having a configure check for sem_timedwait [or
whatever the functions we need are], rather than by piling
up another OS ifdef check.

(If you want to have a go at that it would probably be
useful to read the wiki.qemu.org page on submitting
patches; in particular without a Signed-off-by: line
we can't apply a patch at all.)

-- PMM