qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_tran


From: Wenchao Xia
Subject: Re: [Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_transaction
Date: Wed, 03 Apr 2013 18:35:28 +0800
User-agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130307 Thunderbird/17.0.4

于 2013-4-3 17:03, Kevin Wolf 写道:
Am 03.04.2013 um 07:35 hat Wenchao Xia geschrieben:
于 2013-4-2 21:59, Kevin Wolf 写道:
Am 01.04.2013 um 12:01 hat Wenchao Xia geschrieben:
   Last operaton should be cancelled first.

Signed-off-by: Wenchao Xia <address@hidden>

Should it? This commit message does little to convince me.

Kevin

   I think so, if two request are "snapshot_blkdev ide0 newimage.qcow2",
"snapshot_blkdev_internal ide0 snap0", then in rollback delete of
snap0 would be wrong.

I think this problem exists only because you didn't properly separate
the prepare and the commit stage. If any changes only took effect in a
non-failing commit stage, then you don't ever have to delete a snapshot.
Instead, you just abort the creation of the snapshot.

Kevin

  OK, I got your point, will split bdrv_snapshot_create() before adding
it in qmp_transaction.

--
Best Regards

Wenchao Xia




reply via email to

[Prev in Thread] Current Thread [Next in Thread]