[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/12] target-i386: replace FROM_SYSBUS() with Q
|
From: |
Igor Mammedov |
|
Subject: |
Re: [Qemu-devel] [PATCH 06/12] target-i386: replace FROM_SYSBUS() with QOM type cast |
|
Date: |
Thu, 4 Apr 2013 12:22:18 +0200 |
On Thu, 04 Apr 2013 12:05:22 +0200
Andreas Färber <address@hidden> wrote:
> Am 04.04.2013 11:59, schrieb Igor Mammedov:
> > On Thu, 04 Apr 2013 11:03:53 +0200
> > Andreas Färber <address@hidden> wrote:
> >
> >> Am 21.03.2013 15:28, schrieb Igor Mammedov:
> >>> ... and define type name and type cast macro for kvmvapic according
> >>> to accepted convention.
> >>>
> >>> Signed-off-by: Igor Mammedov <address@hidden>
> >>
> >> This looks great and a cherry-pick candidate if you agree?
> > Np, BTW I have a second similar clean-up in v2 for IOAPIC
> >
> >>
> >> Just wondering, was there a name conflict for shorter VAPIC()?
> >> It's file-local, so doesn't really matter.
> > Nope, I just followed *_DEVICE model like for SYS_BUS_DEVICE()
>
> Okay, then let's avoid unnecessary _DEVICE in your upcoming resend. The
> only other place for actual devices where I remember we needed it was to
> distinguish between PCI host bridge and its PCI device representation on
> the bus. There is also no "Device" in the struct name.
done
>
> Andreas
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
>
--
Regards,
Igor