Re: [Qemu-devel] [PATCH 22/22] add cpu-add qmp command and implement CPU hot-add for target-i386

[Eduardo Habkost]

On Fri, Apr 05, 2013 at 04:37:16PM +0200, Igor Mammedov wrote:
[...]
> diff --git a/qapi-schema.json b/qapi-schema.json
> index db542f6..a760ed5 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -1387,6 +1387,17 @@
>  { 'command': 'cpu', 'data': {'index': 'int'} }
>  
>  ##
> +# @cpu-add
> +#
> +# Adds CPU with specified id
> +#
> +# @id: cpu id of CPU to be created

Can we have the semantics/constraints of "id" documented here? Is it an
arbitrary ID chosen by the caller? Does it have to be the APIC ID? Does
it have to be the index of the CPU in the CPU list? How the IDs of
existing CPUs set using "-smp" are allocated?

I am looking at the code right now to understand how this implementation
works, but the documentation could contain or point to documentation on
how the "id" parameter is used and interpreted.

> +#
> +# Returns: Nothing on success
> +##
> +{ 'command': 'cpu-add', 'data': {'id': 'int'} }
> +
> +##
-- 
Eduardo