Re: [Qemu-devel] [PATCH v2 0/2] configure: fix coroutine backend selection logic

[Brad Smith]

On Thu, Apr 04, 2013 at 11:22:22AM +0100, Peter Maydell wrote:
> Ping^2!
> 
> PS: I note that the patches script doesn't list a patch
> in the 'to:foo' list if foo was forgotten on initial send but
> cc'd on subsequent pings...
> 
> thanks
> -- PMM

I'd love to see this go in. This would remove the need for me to manually
override the coroutine backend to get the sigaltstack backend on OpenBSD.
Our QEMU port / package has been using the sigaltstack backend with 1.2,
1.3, and 1.4.

> On 25 March 2013 13:50, Peter Maydell <address@hidden> wrote:
> > Ping!
> >
> > thanks
> > -- PMM
> >
> > On 14 March 2013 17:57, Peter Maydell <address@hidden> wrote:
> >> The main aim of this patchset is patch 2, which changes the coroutine
> >> backend selection logic so that it goes 'ucontext -> sigaltstack'
> >> rather than 'ucontext -> gthread', since the gthread backend is
> >> broken. To do this properly on all platforms we have to refactor
> >> the code a bit (which it needed anyway).
> >>
> >> The first patch here is a generic configure cleanup to how we print
> >> error messages, which I wanted for the third patch because otherwise
> >> the various error paths would have been rather verbose.
> >>
> >> Changes v1->v2:
> >>  * fix the tests makefile too
> >>  * CONFIG_COROUTINE_BACKEND=foo rather than CONFIG_FOO_COROUTINE=y;
> >>    this simplifies both the configure code and the makefiles
> >>  * dropped the 'move upper()' patch as no longer needed (in this
> >>    series, anyway)
> >>
> >> Peter Maydell (2):
> >>   configure: Provide and use convenience error reporting function
> >>   configure: Don't fall back to gthread coroutine backend
> >>
> >>  Makefile.objs  |   11 +--
> >>  configure      |  257 
> >> ++++++++++++++++++++++++++------------------------------
> >>  tests/Makefile |   14 +--
> >>  3 files changed, 119 insertions(+), 163 deletions(-)
> >>
> >> --
> >> 1.7.9.5
> 
> 
> -- 
> This message has been scanned for viruses and
> dangerous content by MailScanner, and is
> believed to be clean.
> 

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.