[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/12] hw: move memory API to hw/core
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 12/12] hw: move memory API to hw/core |
Date: |
Thu, 11 Apr 2013 20:18:52 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 11/04/2013 19:14, Peter Maydell ha scritto:
> On 11 April 2013 18:09, Paolo Bonzini <address@hidden> wrote:
>> Il 11/04/2013 18:28, Peter Maydell ha scritto:
>>> On 11 April 2013 17:10, Paolo Bonzini <address@hidden> wrote:
>>>>> Signed-off-by: Paolo Bonzini <address@hidden>
>>> This doesn't look right. The MemoryRegion system isn't
>>> hw-specific, it's a part of the basic QEMU emulation
>>> system which provides functionality to hw/ and other
>>> things (like cputlb.c).
>>
>> The accelerator- and target-independent parts of the basic emulation are
>> already in hw/core (not much really, but consider that CPUs are device
>> and depend on hw/core/qdev.c). The memory API is simply the interface
>> between the accelerators and hw/ (boards & device models).
>
> Yes, so it should be provided in the place we put our accelerator
> implementation (ie .): it is functionality and interface exposed
> *to* the code in hw/, not functionality and interface provided
> *by* hw/.
Ok, the historical practice was that qdev core was in hw/, and that's
what I tried to follow. It makes sense either way to me.
But then patch 11 also has to be dropped, otherwise it doesn't make
sense. Michael, what do you think?
Paolo
- [Qemu-devel] [PATCH 08/12] include: avoid useless includes of exec/ headers, (continued)
- [Qemu-devel] [PATCH 08/12] include: avoid useless includes of exec/ headers, Paolo Bonzini, 2013/04/11
- [Qemu-devel] [PATCH 06/12] tpm: reorganize headers and split hardware part, Paolo Bonzini, 2013/04/11
- [Qemu-devel] [PATCH 10/12] exec: remove useless declarations from memory-internal.h, Paolo Bonzini, 2013/04/11
- [Qemu-devel] [PATCH 09/12] memory: move core typedefs to qemu/typedefs.h, Paolo Bonzini, 2013/04/11
- [Qemu-devel] [PATCH 07/12] sysemu: avoid proliferation of include/ subdirectories, Paolo Bonzini, 2013/04/11
- [Qemu-devel] [PATCH 12/12] hw: move memory API to hw/core, Paolo Bonzini, 2013/04/11
[Qemu-devel] [PATCH 11/12] hw: move memory API headers to hw/, Paolo Bonzini, 2013/04/11
Re: [Qemu-devel] [PATCH 00/12] directory reorganization, final part, Anthony Liguori, 2013/04/15