[Qemu-devel] [Bug 1168733] [NEW] reserved identifier violation

[Markus Elfring]

Public bug reported:

I would like to point out that identifiers like the following do not fit to the 
expected naming convention of the C language standard.
- __COMMAND_H__
  
http://git.qemu.org/?p=qemu.git;a=blob;f=cmd.h;hb=64b85a8f2359ca3a995499afaf3c87d8e036e030#l17

- _QEMU_OPTIONS_H_
  
http://git.qemu.org/?p=qemu.git;a=blob;f=qemu-options.h;hb=77bd1119ba43dbd0e73014037a08f8b49136bf6f#l28

Would you like to adjust your selection for unique names?
https://www.securecoding.cert.org/confluence/display/seccode/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29

** Affects: qemu
     Importance: Undecided
         Status: New


** Tags: conflict convention identifiers language programming standard

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1168733

Title:
  reserved identifier violation

Status in QEMU:
  New

Bug description:
  I would like to point out that identifiers like the following do not fit to 
the expected naming convention of the C language standard.
  - __COMMAND_H__
    
http://git.qemu.org/?p=qemu.git;a=blob;f=cmd.h;hb=64b85a8f2359ca3a995499afaf3c87d8e036e030#l17

  - _QEMU_OPTIONS_H_
    
http://git.qemu.org/?p=qemu.git;a=blob;f=qemu-options.h;hb=77bd1119ba43dbd0e73014037a08f8b49136bf6f#l28

  Would you like to adjust your selection for unique names?
  
https://www.securecoding.cert.org/confluence/display/seccode/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1168733/+subscriptions