[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] debugcon: fix compiler warning when open DE
From: |
li guang |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] debugcon: fix compiler warning when open DEBUG_DEBUGCON |
Date: |
Mon, 15 Apr 2013 08:25:58 +0800 |
在 2013-04-12五的 14:19 +0200,Andreas Färber写道:
> Am 12.04.2013 06:12, schrieb liguang:
> > compiler warnings:
> > CC hw/char/debugcon.o
> > hw/char/debugcon.c: In function ‘debugcon_ioport_write’:
> > hw/char/debugcon.c:58: warning: format ‘%02x’ expects type ‘unsigned int’,
> > but argument 3 has type ‘uint64_t’
> > hw/char/debugcon.c: In function ‘debugcon_ioport_read’:
> > hw/char/debugcon.c:70: warning: format ‘%04x’ expects type ‘unsigned int’,
> > but argument 2 has type ‘hwaddr’
> >
> > Signed-off-by: liguang <address@hidden>
> > ---
> > hw/char/debugcon.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/hw/char/debugcon.c b/hw/char/debugcon.c
> > index b52cbeb..4cf07c6 100644
> > --- a/hw/char/debugcon.c
> > +++ b/hw/char/debugcon.c
> > @@ -55,7 +55,7 @@ static void debugcon_ioport_write(void *opaque, hwaddr
> > addr, uint64_t val,
> > unsigned char ch = val;
> >
> > #ifdef DEBUG_DEBUGCON
> > - printf(" [debugcon: write addr=0x%04llx val=0x%02x]\n", addr, val);
> > + printf(" [debugcon: write addr=0x%04llx val=0x%02llx]\n", addr, val);
> > #endif
> >
> > qemu_chr_fe_write(s->chr, &ch, 1);
> > @@ -67,7 +67,7 @@ static uint64_t debugcon_ioport_read(void *opaque, hwaddr
> > addr, unsigned width)
> > DebugconState *s = opaque;
> >
> > #ifdef DEBUG_DEBUGCON
> > - printf("debugcon: read addr=0x%04x\n", addr);
> > + printf("debugcon: read addr=0x%04llx\n", addr);
> > #endif
> >
> > return s->readback;
>
> Please see PRIx comment on 1/3.
>
right, thanks!