[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-arm: Reinsert SRS missing return stateme
|
From: |
Peter Chubb |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-arm: Reinsert SRS missing return statements. |
|
Date: |
Mon, 15 Apr 2013 17:29:56 +1000 |
|
User-agent: |
Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Gojō) APEL/10.8 Emacs/23.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) |
>>>>> "Peter" == Peter Maydell <address@hidden> writes:
Peter> On 15 April 2013 05:50, Peter Chubb <address@hidden>
Peter> wrote:
>>
>>
>> Since patch 81465888c5306cd94abb9847e560796fd13d3c2f target-arm:
>> factor out handling of SRS instruction the SRS instruction has not
>> worked in QEMU.
>>
>> The problem is a return directive that was removed in the
>> refactoring, so after decoding the instruction, qemu would fall
>> through to do stuff that it should not have done.
Peter> Nice catch for the ARM decoder, but not needed for thumb2 I
Peter> think?
It was there in the code that was removed.
I didn't analyse too deeply, as nothing we do uses the thumb version.
Peter C
--
Dr Peter Chubb peter.chubb AT nicta.com.au
http://www.ssrg.nicta.com.au Software Systems Research Group/NICTA