[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio-rng-s390: add properties.
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH] virtio-rng-s390: add properties. |
Date: |
Mon, 15 Apr 2013 15:13:46 +0200 |
On Sun, 14 Apr 2013 15:14:49 +0200
address@hidden wrote:
> From: KONRAD Frederic <address@hidden>
>
> I don't see any reason why these properties are missing.
Acked-by: Cornelia Huck <address@hidden>
>
> Cc: Cornelia Huck <address@hidden>
> Cc: Alexander Graf <address@hidden>
> Signed-off-by: KONRAD Frederic <address@hidden>
>
> Note: Need to apply virtio-rng-refactoring first!
Looks sane here.
> ---
> hw/s390x/s390-virtio-bus.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virtio-bus.c
> index 4d9f2ec..0d915af 100644
> --- a/hw/s390x/s390-virtio-bus.c
> +++ b/hw/s390x/s390-virtio-bus.c
> @@ -514,11 +514,19 @@ static const TypeInfo s390_virtio_serial = {
> .class_init = s390_virtio_serial_class_init,
> };
>
> +static Property s390_virtio_rng_properties[] = {
> + DEFINE_VIRTIO_COMMON_FEATURES(VirtIOS390Device, host_features),
> + DEFINE_VIRTIO_RNG_PROPERTIES(VirtIORNGS390, vdev.conf),
> + DEFINE_PROP_END_OF_LIST(),
> +};
> +
> static void s390_virtio_rng_class_init(ObjectClass *klass, void *data)
> {
> + DeviceClass *dc = DEVICE_CLASS(klass);
> VirtIOS390DeviceClass *k = VIRTIO_S390_DEVICE_CLASS(klass);
>
> k->init = s390_virtio_rng_init;
> + dc->props = s390_virtio_rng_properties;
> }
>
> static const TypeInfo s390_virtio_rng = {