[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/12] configure: fix TPM logic
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 07/12] configure: fix TPM logic |
|
Date: |
Mon, 15 Apr 2013 18:14:19 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 15/04/2013 18:09, Peter Maydell ha scritto:
>> > +if test "$targetos" = Linux && test "$cpu" = i386 -o "$cpu" = x86_64; then
> test -o is deprecated by POSIX; better to use
> if test ... && ( test ... || test ... ); then
>
> in new code.
True, on the other hand "(.*test" has no match at all in configure; and
since we know that $cpu does not begin with a dash, it is portable in
practice.
I would agree with you, but it looks like convention trumps the
suggested practice.
Paolo
- [Qemu-devel] [PULL 00/12] directory reorganization, fixes and final part, Paolo Bonzini, 2013/04/15
- [Qemu-devel] [PATCH 10/12] include: avoid useless includes of exec/ headers, Paolo Bonzini, 2013/04/15
- [Qemu-devel] [PATCH 06/12] acpi.h: make it self contained, Paolo Bonzini, 2013/04/15
- [Qemu-devel] [PATCH 04/12] hw: Add lost ARM core again, Paolo Bonzini, 2013/04/15
- [Qemu-devel] [PATCH 03/12] Fix failure to create q35 machine, Paolo Bonzini, 2013/04/15
- [Qemu-devel] [PATCH 02/12] Add linux-headers to QEMU_INCLUDES, Paolo Bonzini, 2013/04/15
- [Qemu-devel] [PATCH 12/12] exec: remove useless declarations from memory-internal.h, Paolo Bonzini, 2013/04/15
- [Qemu-devel] [PATCH 07/12] configure: fix TPM logic, Paolo Bonzini, 2013/04/15
- Re: [Qemu-devel] [PATCH 07/12] configure: fix TPM logic, Markus Armbruster, 2013/04/16
- [Qemu-devel] [PATCH 01/12] arm: fix location of some include files, Paolo Bonzini, 2013/04/15
- [Qemu-devel] [PATCH 05/12] acpi: move declarations from pc.h to acpi.h, Paolo Bonzini, 2013/04/15
- [Qemu-devel] [PATCH 09/12] sysemu: avoid proliferation of include/ subdirectories, Paolo Bonzini, 2013/04/15
- [Qemu-devel] [PATCH 08/12] tpm: reorganize headers and split hardware part, Paolo Bonzini, 2013/04/15
- [Qemu-devel] [PATCH 11/12] memory: move core typedefs to qemu/typedefs.h, Paolo Bonzini, 2013/04/15
- Re: [Qemu-devel] [PULL 00/12] directory reorganization, fixes and final part, Paolo Bonzini, 2013/04/15