Re: [Qemu-devel] [PATCH 07/15] blkverify: Use bdrv_open options instead of filename

[Eric Blake]

On 04/12/2013 02:48 PM, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/blkverify.c | 94 
> ++++++++++++++++++++++++++++++++++++++++++++-----------
>  1 file changed, 76 insertions(+), 18 deletions(-)
> 

>      /* Parse the blkverify: prefix */
> -    if (strncmp(filename, "blkverify:", strlen("blkverify:"))) {
> -        return -EINVAL;
> +    if (!strstart(filename, "blkverify:", &filename)) {
> +        error_setg(errp, "File name string must start with 'blkverify:'");
> +        return;
>      }
> -    filename += strlen("blkverify:");
>  
>      /* Parse the raw image filename */
>      c = strchr(filename, ':');
>      if (c == NULL) {
> -        return -EINVAL;
> +        error_setg(errp, "blkdebug requires raw copy and original image 
> path");

s/blkdebug/blkverify/

Simple enough fix that I'm still comfortable if you include:

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature