qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH build-breakage] build: include config-{, all-}de


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH build-breakage] build: include config-{, all-}devices.mak after defining CONFIG_SOFTMMU and CONFIG_USER_ONLY
Date: Tue, 16 Apr 2013 13:44:10 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)

Paolo Bonzini <address@hidden> writes:

> Moving the inclusions closer to Makefile, and before rules.mak, makes
> Makefile and Makefile.target more consistent with each other.
>
> Signed-off-by: Paolo Bonzini <address@hidden>

Patch fixes the build with --enable-tpm for me.

Tested-by: Markus Armbruster <address@hidden>

However, subject is too long, and the description should describe the
breakage the patch fixes.  Suggest:

    build: Fix build with --enable-tpm

    Broken in commit 3b8acc1.

    Include config-{, all-}devices.mak after defining CONFIG_SOFTMMU and
    CONFIG_USER_ONLY.  Moving the inclusions closer to Makefile, and
    before rules.mak, makes Makefile and Makefile.target more consistent
    with each other.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]