[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V12 10/18] qmp: add interface query-snapshots
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V12 10/18] qmp: add interface query-snapshots |
Date: |
Wed, 17 Apr 2013 17:03:30 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 |
On 04/13/2013 02:56 AM, Wenchao Xia wrote:
> This interface returns info of valid internal snapshots for whole vm.
>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
> block/qapi.c | 17 +++++++++++++++
> qapi-schema.json | 14 +++++++++++++
> qmp-commands.hx | 58
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 89 insertions(+), 0 deletions(-)
> +query-snapshots
> +---------------
> +
> +Show the internal consistent snapshot information
> +
> +Consistent snapshots are snapshots that exist in all writeable block devices.
> +When 'savevm' takes a snapshot it uses the same ID across all writeable block
> +devices. If a snapshot ID only exists in one block device then it is not a
> +consistent one. Each snapshot is represented by a json-object and the
> returned
> +value is a json-array of all snapshots
Does it really share the same snapshot ID across all block devices, or
is it just the snapshot tag that gets shared? That is, if I have just
disk a, take one snapshot, then hotplug disk b, then take another
snapshot, doesn't that leave me with:
disk a: id 1 tag A, id 2 tag B
disk b: id 1 tag B?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH V12 08/18] block: add image info query function bdrv_query_image_info(), (continued)
- [Qemu-devel] [PATCH V12 08/18] block: add image info query function bdrv_query_image_info(), Wenchao Xia, 2013/04/13
- [Qemu-devel] [PATCH V12 07/18] block: change VM snapshot checking logic, Wenchao Xia, 2013/04/13
- [Qemu-devel] [PATCH V12 09/18] block: move qmp_query_block() and bdrv_query_info() to block/qapi.c, Wenchao Xia, 2013/04/13
- [Qemu-devel] [PATCH V12 02/18] block: distinguish id and name in bdrv_find_snapshot(), Wenchao Xia, 2013/04/13
- [Qemu-devel] [PATCH V12 01/18] block: move bdrv_snapshot_find() to block/snapshot.c, Wenchao Xia, 2013/04/13
- [Qemu-devel] [PATCH V12 10/18] qmp: add interface query-snapshots, Wenchao Xia, 2013/04/13
- Re: [Qemu-devel] [PATCH V12 10/18] qmp: add interface query-snapshots,
Eric Blake <=
- [Qemu-devel] [PATCH V12 11/18] qmp: add recursive member in ImageInfo, Wenchao Xia, 2013/04/13
- [Qemu-devel] [PATCH V12 06/18] block: add check for VM snapshot in bdrv_query_snapshot_info_list(), Wenchao Xia, 2013/04/13
- [Qemu-devel] [PATCH V12 13/18] block: move bdrv_snapshot_dump() and dump_human_image_info() to block/qapi.c, Wenchao Xia, 2013/04/13
- [Qemu-devel] [PATCH V12 15/18] hmp: add function hmp_info_snapshots(), Wenchao Xia, 2013/04/13
- [Qemu-devel] [PATCH V12 17/18] hmp: show ImageInfo in 'info block', Wenchao Xia, 2013/04/13
- [Qemu-devel] [PATCH V12 14/18] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump(), Wenchao Xia, 2013/04/13