[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/12] cpu: Pass CPUState to *cpu_synchronize_po
From: |
Gleb Natapov |
Subject: |
Re: [Qemu-devel] [PATCH 10/12] cpu: Pass CPUState to *cpu_synchronize_post*() |
Date: |
Thu, 18 Apr 2013 12:18:43 +0300 |
On Tue, Apr 16, 2013 at 02:46:47AM +0200, Andreas Färber wrote:
> From: Igor Mammedov <address@hidden>
>
> ... so it could be called without requiring CPUArchState.
>
> Signed-off-by: Igor Mammedov <address@hidden>
> Reviewed-by: Eduardo Habkost <address@hidden>
> Signed-off-by: Andreas Färber <address@hidden>
Acked-by: Gleb Natapov <address@hidden>
> ---
> cpus.c | 4 ++--
> include/sysemu/kvm.h | 12 ++++++------
> kvm-all.c | 8 ++------
> kvm-stub.c | 4 ++--
> 4 files changed, 12 insertions(+), 16 deletions(-)
>
> diff --git a/cpus.c b/cpus.c
> index 97e9ab4..c15ff6c 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -419,7 +419,7 @@ void cpu_synchronize_all_post_reset(void)
> CPUArchState *cpu;
>
> for (cpu = first_cpu; cpu; cpu = cpu->next_cpu) {
> - cpu_synchronize_post_reset(cpu);
> + cpu_synchronize_post_reset(ENV_GET_CPU(cpu));
> }
> }
>
> @@ -428,7 +428,7 @@ void cpu_synchronize_all_post_init(void)
> CPUArchState *cpu;
>
> for (cpu = first_cpu; cpu; cpu = cpu->next_cpu) {
> - cpu_synchronize_post_init(cpu);
> + cpu_synchronize_post_init(ENV_GET_CPU(cpu));
> }
> }
>
> diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h
> index f2d97b5..495e6f8 100644
> --- a/include/sysemu/kvm.h
> +++ b/include/sysemu/kvm.h
> @@ -250,8 +250,8 @@ int kvm_check_extension(KVMState *s, unsigned int
> extension);
> uint32_t kvm_arch_get_supported_cpuid(KVMState *env, uint32_t function,
> uint32_t index, int reg);
> void kvm_cpu_synchronize_state(CPUArchState *env);
> -void kvm_cpu_synchronize_post_reset(CPUArchState *env);
> -void kvm_cpu_synchronize_post_init(CPUArchState *env);
> +void kvm_cpu_synchronize_post_reset(CPUState *cpu);
> +void kvm_cpu_synchronize_post_init(CPUState *cpu);
>
> /* generic hooks - to be moved/refactored once there are more users */
>
> @@ -262,17 +262,17 @@ static inline void cpu_synchronize_state(CPUArchState
> *env)
> }
> }
>
> -static inline void cpu_synchronize_post_reset(CPUArchState *env)
> +static inline void cpu_synchronize_post_reset(CPUState *cpu)
> {
> if (kvm_enabled()) {
> - kvm_cpu_synchronize_post_reset(env);
> + kvm_cpu_synchronize_post_reset(cpu);
> }
> }
>
> -static inline void cpu_synchronize_post_init(CPUArchState *env)
> +static inline void cpu_synchronize_post_init(CPUState *cpu)
> {
> if (kvm_enabled()) {
> - kvm_cpu_synchronize_post_init(env);
> + kvm_cpu_synchronize_post_init(cpu);
> }
> }
>
> diff --git a/kvm-all.c b/kvm-all.c
> index 9b433d3..fc4e17c 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -1510,18 +1510,14 @@ void kvm_cpu_synchronize_state(CPUArchState *env)
> }
> }
>
> -void kvm_cpu_synchronize_post_reset(CPUArchState *env)
> +void kvm_cpu_synchronize_post_reset(CPUState *cpu)
> {
> - CPUState *cpu = ENV_GET_CPU(env);
> -
> kvm_arch_put_registers(cpu, KVM_PUT_RESET_STATE);
> cpu->kvm_vcpu_dirty = false;
> }
>
> -void kvm_cpu_synchronize_post_init(CPUArchState *env)
> +void kvm_cpu_synchronize_post_init(CPUState *cpu)
> {
> - CPUState *cpu = ENV_GET_CPU(env);
> -
> kvm_arch_put_registers(cpu, KVM_PUT_FULL_STATE);
> cpu->kvm_vcpu_dirty = false;
> }
> diff --git a/kvm-stub.c b/kvm-stub.c
> index f6137d3..723a813 100644
> --- a/kvm-stub.c
> +++ b/kvm-stub.c
> @@ -41,11 +41,11 @@ void kvm_cpu_synchronize_state(CPUArchState *env)
> {
> }
>
> -void kvm_cpu_synchronize_post_reset(CPUArchState *env)
> +void kvm_cpu_synchronize_post_reset(CPUState *cpu)
> {
> }
>
> -void kvm_cpu_synchronize_post_init(CPUArchState *env)
> +void kvm_cpu_synchronize_post_init(CPUState *cpu)
> {
> }
>
> --
> 1.8.1.4
--
Gleb.
- [Qemu-devel] [PATCH 02/12] target-i386: Improve -cpu ? features output, (continued)
- [Qemu-devel] [PATCH 02/12] target-i386: Improve -cpu ? features output, Andreas Färber, 2013/04/15
- [Qemu-devel] [PATCH 01/12] target-i386: Fix including "host" in -cpu ? output, Andreas Färber, 2013/04/15
- [Qemu-devel] [PATCH 03/12] qdev: Add qdev property for bool type, Andreas Färber, 2013/04/15
- [Qemu-devel] [PATCH 06/12] kvmvapic: Replace FROM_SYSBUS() with QOM type cast, Andreas Färber, 2013/04/15
- [Qemu-devel] [PATCH 04/12] target-i386: Consolidate error propagation in x86_cpu_realizefn(), Andreas Färber, 2013/04/15
- [Qemu-devel] [PATCH 07/12] ioapic: Replace FROM_SYSBUS() with QOM type cast, Andreas Färber, 2013/04/15
- [Qemu-devel] [PATCH 05/12] target-i386: Split APIC creation from initialization in x86_cpu_realizefn(), Andreas Färber, 2013/04/15
- [Qemu-devel] [PATCH 11/12] qdev: Set device's parent before calling realize() down inheritance chain, Andreas Färber, 2013/04/15
- [Qemu-devel] [PATCH 08/12] target-i386/cpu.c: Coding style fixes, Andreas Färber, 2013/04/15
- [Qemu-devel] [PATCH 10/12] cpu: Pass CPUState to *cpu_synchronize_post*(), Andreas Färber, 2013/04/15
- Re: [Qemu-devel] [PATCH 10/12] cpu: Pass CPUState to *cpu_synchronize_post*(),
Gleb Natapov <=
- [Qemu-devel] [PATCH 09/12] target-i386: Split out CPU creation and features parsing, Andreas Färber, 2013/04/15
- [Qemu-devel] [PATCH 12/12] target-cris: Override do_interrupt for pre-v32 CPU cores, Andreas Färber, 2013/04/15