Re: [Qemu-devel] [PATCH RFC] vhost: fix vhost force with msix=off

[Alexander Graf]

On 15.04.2013, at 16:40, Michael S. Tsirkin wrote:

> In response to a bug report on IRC: this should fix it I think?
> Need to test properly but out of time for today,
> compiled only. Hope this helps.
> 
> Signed-off-by: Michael S. Tsirkin <address@hidden>

This does indeed make level interrupts work with vhost. Thanks a lot!

Tested-by: Alexander Graf <address@hidden>


Alex

> 
> diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
> index 8bba0f3..d0fcc6c 100644
> --- a/hw/virtio/virtio-pci.c
> +++ b/hw/virtio/virtio-pci.c
> @@ -758,6 +758,10 @@ static int virtio_pci_set_guest_notifier(DeviceState *d, 
> int n, bool assign,
>         event_notifier_cleanup(notifier);
>     }
> 
> +    if (!msix_enabled(&proxy->pci_dev) && proxy->vdev->guest_notifier_mask) {
> +        proxy->vdev->guest_notifier_mask(proxy->vdev, n, !assign);
> +    }
> +
>     return 0;
> }
>