Re: [Qemu-devel] [PATCH 11/16] introduce ICC bus/device/bridge

[Paolo Bonzini]

Il 22/04/2013 13:39, Peter Maydell ha scritto:
>> > ... to provide hotplug-able bus.
>> >
>> > * icc-bridge will serve as a parent for icc-bus and provide
>> >   mmio mapping services to child icc-devices.
>> > * icc-device will replace SysBusDevice as a parent of APIC
>> >   and IOAPIC devices.
>> >
>> > Signed-off-by: Igor Mammedov <address@hidden>
>> > ---
>> > v2:
>> >   * Rebase on top the last HW reorganization series.
>> >   * Move hw/icc_bus.c into hw/cpu/ and hw/icc_bus.h include/hw/i386/
> This seems inconsistent. I think the header should be in
> include/hw/cpu/ to match the location of the .c file.

Agreed.

Paolo