[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/21 DISGISED v6] acpi_piix4: add infrastructur
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH 10/21 DISGISED v6] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest |
Date: |
Wed, 24 Apr 2013 19:22:21 +0200 |
On Wed, 24 Apr 2013 18:09:11 +0200
Andreas Färber <address@hidden> wrote:
> Am 24.04.2013 18:03, schrieb Eduardo Habkost:
> > On Wed, Apr 24, 2013 at 05:56:46PM +0200, Igor Mammedov wrote:
> >> On Tue, 23 Apr 2013 18:27:11 +0200
> >> Igor Mammedov <address@hidden> wrote:
> >>
> >> NACK
> >>
> >>
> >> gpe_cpu.sts isn't need to be migrated, since CPU hotpluging during
> >> migration just doesn't work, since destination QEMU has to be started
> >> with all present in guest CPUs (including hotplugged).
> >> i.e. src-qemu -smp 2,max-cpus=4; cpu-add id=2; dst-qemu -smp 3,max-cpus=4
> >> Destination QEMU will recreate the same gpe_cpu.sts=t'111' bitmap as
> >> on source by calling qemu_for_each_cpu(piix4_init_cpu_status,
> >> &s->gpe_cpu);
> >> since it has been started with 3 CPUs on command line.
> >>
> >> tested on ping pong migration, It works as expected without gpe_cpu.sts
> >> migrated.
> >> I'll post v7 to this thread shortly.
> >
> > Are we going to make the cpu-add command fail in case it gets called
> > during migration?
>
> I would rather suggest to throw an Error* on realize, if this can be
> detected.
it would be better not to start/allow hot add at all if migration in
progress and let it complete. it probably could be made generic???
>
> Andreas
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
Regards,
Igor
- Re: [Qemu-devel] [PATCH 10/21] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest, (continued)
Re: [Qemu-devel] [PATCH 10/21] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest, Juan Quintela, 2013/04/23
[Qemu-devel] [PATCH 10/21 DISGISED v6] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest, Igor Mammedov, 2013/04/23
[Qemu-devel] [PATCH 08/19 v7] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest, Igor Mammedov, 2013/04/24
[Qemu-devel] [PATCH 10/21 v8] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest, Igor Mammedov, 2013/04/24
[Qemu-devel] [PATCH 15/21] target-i386: kvmvapic: make expilict dependency on sysbus.h, Igor Mammedov, 2013/04/23
[Qemu-devel] [PATCH 18/21] target-i386: move IOAPIC to ICC bus, Igor Mammedov, 2013/04/23
[Qemu-devel] [PATCH 16/21] target-i386: move APIC to ICC bus, Igor Mammedov, 2013/04/23
[Qemu-devel] [PATCH 19/21] add hot_add_cpu hook to QEMUMachine and export machine_args, Igor Mammedov, 2013/04/23