[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 04/12] qapi: Convert delvm
From: |
Wenchao Xia |
Subject: |
Re: [Qemu-devel] [PATCH v2 04/12] qapi: Convert delvm |
Date: |
Thu, 25 Apr 2013 14:58:15 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 |
+ char buf[256];
I know this fixed-size buffer is just a copy-and-paste from other code
that displays snapshot information, but I really hate it. On the other
hand, I can tolerate if we have it as an intermediate step between two
series that both land in the same release.
If your series goes in first, Wenchao's series that cleans up the
fixed-size buffer will need to be rebased to tweak this additional spot.
If Wenchao's patches go in first, then you will have a bit of rebase
work to do. Since we are already deferring this series into 1.6, I
think it would be nice to post a unified series of the best of both
authors, rather than continuing to waffle on what should go in first.
That would be a very long serial, taking time to rebase for any code
change in it, that is why I haven't consider it before.
[And if I keep saying that often enough, I may end up getting my hands
dirty and becoming the person that posts such a unified patch, although
Pls don't, I guess it would not be a good experience working in a
long serial which may need modification later.
generally I don't like forcefully taking over someone else's initial work.]
My serial serves mainly for block image's info querying, different
with Pavel, one serial fixing all is not easy to make.
Instead, I'll send out small serial change the common part:
1 better bdrv_snapshot_find().
2 hmp/qemu-img dumping info code().
Then we rebase on it, as two serial, do you think it is OK?
+++ b/qapi-schema.json
--
Best Regards
Wenchao Xia
- [Qemu-devel] [PATCH v2 03/12] savevm: update bdrv_snapshot_find() to find snapshot by id or name and add error parameter, (continued)
[Qemu-devel] [PATCH v2 04/12] qapi: Convert delvm, Pavel Hrdina, 2013/04/24
[Qemu-devel] [PATCH v2 10/12] savevm: update error reporting of qemu_savevm_state() and related functions, Pavel Hrdina, 2013/04/24
[Qemu-devel] [PATCH v2 08/12] qapi: Convert loadvm, Pavel Hrdina, 2013/04/24
[Qemu-devel] [PATCH v2 09/12] block: update error reporting for bdrv_snapshot_create() and related functions, Pavel Hrdina, 2013/04/24
[Qemu-devel] [PATCH v2 05/12] block: update error reporting for bdrv_snapshot_goto() and related functions, Pavel Hrdina, 2013/04/24
[Qemu-devel] [PATCH v2 11/12] qapi: Convert savevm, Pavel Hrdina, 2013/04/24
[Qemu-devel] [PATCH v2 12/12] savevm: remove backward compatibility from bdrv_snapshot_find(), Pavel Hrdina, 2013/04/24
[Qemu-devel] [PATCH v2 06/12] block: update error reporting for bdrv_snapshot_list() and related functions, Pavel Hrdina, 2013/04/24