qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 0/6] vmdk: zeroed-grain GTE support


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH v3 0/6] vmdk: zeroed-grain GTE support
Date: Thu, 25 Apr 2013 15:25:52 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Wed, Apr 24, 2013 at 08:44:29PM +0800, Fam Zheng wrote:
> Added support for zeroed-grain GTE to VMDK according to VMDK Spec 5.0[1].
> 
> [1] Virtual Disk Format 5.0 - VMware,
>     http://www.vmware.com/support/developer/vddk/vmdk_50_technote.pdf?src=vmdk
> 
> Changes since v2:
>  - all: Added 5/6 (vmdk: store fields of VmdkMetaData in cpu endian)
>  - 6/6: Avoid side-effect of vmdk_L2update.
>         Change function comment to gtkdoc stype.
>         Fix VMDK4_FLAG_ZG.

I left some comments.  The trickiest one is forgetting to update the
l2_cache[].  If more vmdk.c features are added in the future, please
first switch to common caching code that qcow2 uses.  Right now just
fixing the missing cache update is fine.

Dong Xu Wang <address@hidden> has moved the qcow2 cache code
to a common place.  His patches aren't merged yet but should be soon.

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]