qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 02/12] block: update error reporting for bdrv


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH v2 02/12] block: update error reporting for bdrv_snapshot_delete() and related functions
Date: Thu, 25 Apr 2013 15:42:22 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Wed, Apr 24, 2013 at 05:32:00PM +0200, Pavel Hrdina wrote:
> diff --git a/block/sheepdog.c b/block/sheepdog.c
> index 20b5d06..7e0610f 100644
> --- a/block/sheepdog.c
> +++ b/block/sheepdog.c
> @@ -1937,10 +1937,12 @@ out:
>      return ret;
>  }
>  
> -static int sd_snapshot_delete(BlockDriverState *bs, const char *snapshot_id)
> +static void sd_snapshot_delete(BlockDriverState *bs,
> +                               const char *snapshot_id,
> +                               Error **errp)
>  {
>      /* FIXME: Delete specified snapshot id.  */
> -    return 0;
> +    error_setg(errp, "Deleting snapshot is not supported");
>  }

Careful, this could break existing tests or applications that expect
snapshot delete to lie.  I suggest *not* setting the error for now,
unless Kazutaka agrees it's okay to start erroring now.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]