[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_du
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump() |
Date: |
Fri, 26 Apr 2013 16:46:57 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Apr 26, 2013 at 05:31:15PM +0800, Wenchao Xia wrote:
> @@ -2586,10 +2585,12 @@ void do_info_snapshots(Monitor *mon, const QDict
> *qdict)
> }
>
> if (total > 0) {
> - monitor_printf(mon, "%s\n", bdrv_snapshot_dump(buf, sizeof(buf),
> NULL));
> + bdrv_snapshot_dump(NULL);
> + monitor_printf(mon, "\n");
Luiz: any issue with mixing monitor_printf(mon) and
monitor_vprintf(cur_mon) calls? I guess there was a reason for
explicitly passing mon instead of relying on cur_mon.
> for (i = 0; i < total; i++) {
> sn = &sn_tab[available_snapshots[i]];
> - monitor_printf(mon, "%s\n", bdrv_snapshot_dump(buf, sizeof(buf),
> sn));
> + bdrv_snapshot_dump(sn);
> + monitor_printf(mon, "\n");
> }
> } else {
> monitor_printf(mon, "There is no suitable snapshot available\n");
> diff --git a/util/qemu-error.c b/util/qemu-error.c
> index 08a36f4..a47bf32 100644
> --- a/util/qemu-error.c
> +++ b/util/qemu-error.c
> @@ -213,3 +213,21 @@ void error_report(const char *fmt, ...)
> va_end(ap);
> error_printf("\n");
> }
> +
> +/*
> + * Print to current monitor if we have one, else to stdout. It is similar
> with
> + * error_printf().
> + * TODO just like error_vprintf()
TODO?
- [Qemu-devel] [PATCH 2/7] block: move bdrv_snapshot_find() to block/snapshot.c, (continued)
- [Qemu-devel] [PATCH 2/7] block: move bdrv_snapshot_find() to block/snapshot.c, Wenchao Xia, 2013/04/26
- [Qemu-devel] [PATCH 3/7] block: move snapshot code in block.c to block/snapshot.c, Wenchao Xia, 2013/04/26
- [Qemu-devel] [PATCH 4/7] block: distinguish id and name in bdrv_find_snapshot(), Wenchao Xia, 2013/04/26
- [Qemu-devel] [PATCH 5/7] block: move collect_snapshots() and collect_image_info() to block/qapi.c, Wenchao Xia, 2013/04/26
- [Qemu-devel] [PATCH 6/7] block: move qmp and info dump related code to block/qapi.c, Wenchao Xia, 2013/04/26
- [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump(), Wenchao Xia, 2013/04/26
- Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump(),
Stefan Hajnoczi <=