Re: [Qemu-devel] [PATCH for-1.5 v3 08/15] xilinx_spips: Implement automatic CS

[Peter Crosthwaite]

Hi Peter,

On Mon, Apr 29, 2013 at 10:14 PM, Peter Maydell
<address@hidden> wrote:
> On 22 April 2013 06:16,  <address@hidden> wrote:
>> From: Peter Crosthwaite <address@hidden>
>>
>> Implement the automatic CS control feature. If the MANUAL_CS bit is
>> cleared then the chip select stay de-asserted as long as the tx FIFO
>> is empty.
>>
>> Signed-off-by: Peter Crosthwaite <address@hidden>
>> Reviewed-by: Peter Maydell <address@hidden>
>
> Doesn't compile:
>
> hw/ssi/xilinx_spips.c: In function ‘xilinx_spips_update_cs_lines’:
> hw/ssi/xilinx_spips.c:215:17: error: implicit declaration of function
> ‘DB_PRINT_L’ [-Werror=implicit-function-declaration]
> hw/ssi/xilinx_spips.c:215:17: error: nested extern declaration of
> ‘DB_PRINT_L’ [-Werror=nested-externs]
> cc1: all warnings being treated as errors
>
> (you don't introduce that macro until later).
>

Nice catch. Thanks. I have now added individual patch compile testing
to my format-patch wrapper script to catch these. Will fix.

Regards,
Peter

> -- PMM
>