Re: [Qemu-devel] [PATCH qom-cpu 0/9] x86: feature words array (v11) + "feature-words" property

[Andreas Färber]

Am 22.04.2013 21:00, schrieb Eduardo Habkost:
> This series includes the previous "replace cpuid_*features fields with a 
> feature
> word array" series.
> 
> The first 4 patches already have a Reviewed-by from Igor, they correspond to 
> v10
> plus a small indent fix requested by him.
> 
> As the cpuid_*features series was holding my 
> "feature-words"/"filtered-features"
> series (previously sent as RFC), I am now sending both as a single series, to
> try to get "feature-words"/"filtered-features" some attention and try to get 
> it
> included in 1.5.
> 
> The "feature-words"/"filtered-features" mechanism is very important for 
> libvirt,
> to allow it to ensure the guest is getting the required set of CPU features, 
> as
> configured by the user.
> 
> 
> Eduardo Habkost (9):
>   target-i386: cleanup: Group together level, xlevel, xlevel2 fields
>   target-i386/kvm.c: Code formatting changes
>   target-i386/cpu.c: Break lines so they don't get too long
>   target-i386: Replace cpuid_*features fields with a feature word array

Thanks, applied these to qom-cpu:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu

These had been around for quite some time and I have reviewed the first
three line by line; for the fourth I have looked at the script sources
and trust Igor's review. Thanks for repeatedly rebasing this, Eduardo!


>   target-i386: Add ECX information to FeatureWordInfo

This one is lacking Reviewed-by / Acked-by ...

>   target-i386: Add "feature-words" property
>   target-i386: Use FeatureWord loop on filter_features_for_kvm()

... and this one seems to depend on it.

>   target-i386: Introduce X86CPU.filtered_features field
>   target-i386: Add "filtered-features" property to X86CPU

As mentioned earlier I'd prefer to defer the property design rather than
putting it lightly reviewed into 1.5 and living with some ABI.
If libvirt urgently needs this info, this series needs to be reviewed
and sorted out until the weekend (Hard Freeze on Monday).

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg