[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] memory: Replace open-coded memory_region_is_rom
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] memory: Replace open-coded memory_region_is_romd |
Date: |
Mon, 06 May 2013 18:26:14 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 06/05/2013 18:07, Jan Kiszka ha scritto:
> Improves readability.
>
> Signed-off-by: Jan Kiszka <address@hidden>
> ---
> translate-all.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/translate-all.c b/translate-all.c
> index da93608..0d84b0d 100644
> --- a/translate-all.c
> +++ b/translate-all.c
> @@ -1359,7 +1359,7 @@ void tb_invalidate_phys_addr(hwaddr addr)
> section = phys_page_find(address_space_memory.dispatch,
> addr >> TARGET_PAGE_BITS);
> if (!(memory_region_is_ram(section->mr)
> - || (section->mr->rom_device && section->mr->readable))) {
> + || memory_region_is_romd(section->mr))) {
> return;
> }
> ram_addr = (memory_region_get_ram_addr(section->mr) & TARGET_PAGE_MASK)
>
Not trivial enough for qemu-trivial, let's open a memory branch for 1.6.
Any volunteers for co-maintaining it? :)
Paolo