[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 9/9] Make monitor command 'dump-guest-memory' du
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 9/9] Make monitor command 'dump-guest-memory' dump in kdump-compressed format |
|
Date: |
Wed, 08 May 2013 11:16:29 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 |
On 05/08/2013 02:50 AM, qiaonuohan wrote:
>
> Thanks for your suggestion. I will fix it like:
>
> { 'enum': 'DumpCompressionFormat',
> 'data': [ 'zlib', 'lzo', 'snappy' ] }
>
> For zlib is treated as the default compression format, and
> 'uncompressed' won't be an option.
No, I was serious that you need to provide 'uncompressed' as an explicit
enum value. It is very annoying to toggle between four states (three
compression formats and a fourth state of no compression) when the
fourth is available only by omitting a parameter. The default MUST be
'uncompressed' for backwards-compatibility, not 'zlib'.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH 7/9] Add API to free buf used by creating header, bitmap and page, Qiao Nuohan, 2013/05/07
[Qemu-devel] [PATCH 3/9] Move include and struct definition to dump.h, Qiao Nuohan, 2013/05/07
[Qemu-devel] [PATCH 2/9] Add API to manipulate cache_data, Qiao Nuohan, 2013/05/07
[Qemu-devel] [PATCH 1/9] Add API to manipulate dump_bitmap, Qiao Nuohan, 2013/05/07