[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] osdep.h: include sys/types.h for ssize_t defini
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] osdep.h: include sys/types.h for ssize_t definition |
Date: |
Fri, 10 May 2013 16:24:09 +0100 |
On 10 May 2013 16:16, Igor Mitsyanko <address@hidden> wrote:
> This fixes build for mingw32
>
> Signed-off-by: Igor Mitsyanko <address@hidden>
> ---
> include/qemu/osdep.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
> index 42545bc..17946a3 100644
> --- a/include/qemu/osdep.h
> +++ b/include/qemu/osdep.h
> @@ -163,6 +163,8 @@ int qemu_create_pidfile(const char *filename);
> int qemu_get_thread_id(void);
>
> #ifndef CONFIG_IOVEC
> +#include <sys/types.h>
> +
This is quite a long way down to have a system #include.
Can we just take the existing include of sys/types.h at
the top of the file out of its current #ifdef __OpenBSD__
guard ?
(http://hacks.owlfolio.org/header-survey/ has a full row
of greens for sys/types.h so this should be safe.)
thanks
-- PMM