[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/8] pci: Don't del_subgregion on a non subregio
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 2/8] pci: Don't del_subgregion on a non subregion |
Date: |
Mon, 13 May 2013 14:14:01 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 13/05/2013 12:54, David Gibson ha scritto:
> Currently do_pci_unregister_device() calls memory_region_del_subregion()
> on the device's bus_master_enable_region and the device's iommu region.
> But the bus_master_enable_region is an _alias_ to the iommu region, the
> iommu region is _not_ a subregion of it. I suspect this has slipped by
> only because PCI hot unplug has not been tested with the new PCI DMA
> address space handling. This patch removes the bogus call.
>
> Signed-off-by: David Gibson <address@hidden>
> ---
> hw/pci/pci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/pci/pci.c b/hw/pci/pci.c
> index 0ba39e6..58d3f69 100644
> --- a/hw/pci/pci.c
> +++ b/hw/pci/pci.c
> @@ -875,7 +875,6 @@ static void do_pci_unregister_device(PCIDevice *pci_dev)
> pci_config_free(pci_dev);
>
> address_space_destroy(&pci_dev->bus_master_as);
> - memory_region_del_subregion(&pci_dev->bus_master_enable_region,
> pci_dev->iommu);
> pci_dev->bus->iommu_dtor_fn(pci_dev->iommu);
> memory_region_destroy(&pci_dev->bus_master_enable_region);
> }
>
Applied to iommu branch, thanks.
Paolo
- [Qemu-devel] [0/8] RFC: VFIO and guest side IOMMUs, revisited, David Gibson, 2013/05/13
- [Qemu-devel] [PATCH 2/8] pci: Don't del_subgregion on a non subregion, David Gibson, 2013/05/13
- Re: [Qemu-devel] [PATCH 2/8] pci: Don't del_subgregion on a non subregion,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 4/8] pci: Use AddressSpace rather than MemoryRegion to represent PCI DMA space, David Gibson, 2013/05/13
- [Qemu-devel] [PATCH 1/8] iommu: Fix compile error in ioapic.c, David Gibson, 2013/05/13
- [Qemu-devel] [PATCH 7/8] vfio: Introduce VFIO address spaces, David Gibson, 2013/05/13
- [Qemu-devel] [PATCH 6/8] memory: Sanity check that no listeners remain on a destroyed AddressSpace, David Gibson, 2013/05/13