Re: [Qemu-devel] [PATCH v3 11/28] libcacard: teach vscclient to use GMainLoop for portability

[Laurent Desnogues]

Hi,

it looks like some "new" glib functions are used here which are
not available in older glib.

On Mon, Apr 22, 2013 at 5:04 PM, Alon Levy <address@hidden> wrote:
> From: Marc-André Lureau <address@hidden>
>
> This version handles non-blocking sending and receiving from the
> socket.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  libcacard/vscclient.c | 391 
> +++++++++++++++++++++++++++++++-------------------
>  1 file changed, 246 insertions(+), 145 deletions(-)
>
> diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c
> index 5f47634..ac23647 100644
> --- a/libcacard/vscclient.c
> +++ b/libcacard/vscclient.c
[...]
> +        default:
> +            g_warn_if_reached();

g_warn_if_reached was added in version 2.16.

[...]
> +    g_io_channel_unref(channel_stdin);
> +    g_io_channel_unref(channel_socket);
> +    g_byte_array_unref(socket_to_send);

g_byte_array_unref isn't in glib 2.12, I couldn't find when it was
added.

I guess both are good candidates for inclusion in glib-compat.h.


Thanks,

Laurent