[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 01/13] apic: rename apic specific bitopts
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH RFC 01/13] apic: rename apic specific bitopts |
Date: |
Mon, 13 May 2013 23:29:41 +0300 |
On Mon, May 13, 2013 at 09:22:20PM +0100, Peter Maydell wrote:
> On 13 May 2013 21:00, Michael S. Tsirkin <address@hidden> wrote:
> > apic has its own version of bitops, with the
> > difference that it works on u32 and not long.
> > Add apic_ prefix to avoid namespace clashes.
>
> Wouldn't it be better to consolidate so we only have
> one set of bitops rather than a local set in this file?
>
> thanks
> -- PMM
Yes but I'd like this patchset to focus on acpi.
ATM including bitops in pc.h gives build errors.
Thus this trivial patch, can be tested by comparing binary.
Consolidation is better done in a separate patchset,
and would need more testing.
Any chance you can do this on top of this?
--
MST
- [Qemu-devel] [PATCH RFC 00/13] qemu: generate acpi tables for the guest, Michael S. Tsirkin, 2013/05/13
- [Qemu-devel] [PATCH RFC 03/13] refer to FWCfgState explicitly, Michael S. Tsirkin, 2013/05/13
- [Qemu-devel] [PATCH RFC 02/13] hw/i386/pc.c: move IO_APIC_DEFAULT_ADDRESS to include/hw/i386/apic.h, Michael S. Tsirkin, 2013/05/13
- [Qemu-devel] [PATCH RFC 01/13] apic: rename apic specific bitopts, Michael S. Tsirkin, 2013/05/13
- [Qemu-devel] [PATCH RFC 04/13] fw_cfg: move typedef to qemu/typedefs.h, Michael S. Tsirkin, 2013/05/13
- [Qemu-devel] [PATCH RFC 06/13] acpi: add rules to compile ASL source, Michael S. Tsirkin, 2013/05/13
- [Qemu-devel] [PATCH RFC 05/13] i386: add ACPI table files from seabios, Michael S. Tsirkin, 2013/05/13
- [Qemu-devel] [PATCH RFC 08/13] range: add Range structure, Michael S. Tsirkin, 2013/05/13
- [Qemu-devel] [PATCH RFC 13/13] pc: reuse guest info for legacy fw cfg, Michael S. Tsirkin, 2013/05/13
- [Qemu-devel] [PATCH RFC 09/13] i386: add bios linker/loader, Michael S. Tsirkin, 2013/05/13
- [Qemu-devel] [PATCH RFC 07/13] acpi: pre-compiled ASL files, Michael S. Tsirkin, 2013/05/13
- [Qemu-devel] [PATCH RFC 10/13] i386: generate pc guest info, Michael S. Tsirkin, 2013/05/13