Re: [Qemu-devel] [PATCH 9/9 v2] Make monitor command 'dump-guest-memory' dump in kdump-compressed format

[Eric Blake]

On 05/14/2013 11:27 PM, Qiao Nuohan wrote:

>>> +static int dump_init(DumpState *s, int fd, bool compress_format,
>>> +                    DumpGuestMemoryFormat format, bool paging,
>>> +                    bool has_filter, int64_t begin, int64_t length,
>>> Error **errp)
>>>   {
>>
>> Why do you need compress_format as a separate parameter, when that
>> information is redundant with the contents of format?
> 
> I need this variable to decide whether in kdump-compressed format or
> not. Without using it, I need to repeat "has_format && format !=
> DUMP_GUEST_MEMORY_FORMAT_ELF" three times.

Then set it up as a local stack-allocated variable within the function
body.  No need to pass it as part of the function signature, to make all
callers pass redundant information.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature