qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 5/8] blockdev: rename BlkTransactionStates to


From: Wenchao Xia
Subject: Re: [Qemu-devel] [PATCH v3 5/8] blockdev: rename BlkTransactionStates to singular
Date: Thu, 16 May 2013 10:28:44 +0800
User-agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130328 Thunderbird/17.0.5

> The QMP 'transaction' command keeps a list of in-flight transactions.
> The transaction state structure is called BlkTransactionStates even
> though it only deals with a single transaction.  The only plural thing
> is the linked list of transaction states.
> 
> I find it confusing to call the single structure "States".  This patch
> renames it to "State", just like BlockDriverState is singular.
> 
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
>   blockdev.c | 104 
> ++++++++++++++++++++++++++++++-------------------------------
>   1 file changed, 52 insertions(+), 52 deletions(-)
> 

Reviewed-by: Wenchao Xia <address@hidden>




-- 
Best Regards

Wenchao Xia




reply via email to

[Prev in Thread] Current Thread [Next in Thread]