Re: [Qemu-devel] [PATCH 21/30] memory: Add iommu map/unmap notifiers

[Paolo Bonzini]

Il 23/05/2013 20:27, Peter Maydell ha scritto:
> On 21 May 2013 11:57, Paolo Bonzini <address@hidden> wrote:
>> From: David Gibson <address@hidden>
>>
>> This patch adds a NotifierList to MemoryRegions which represent IOMMUs
>> allowing other parts of the code to register interest in mappings or
>> unmappings from the IOMMU.  All IOMMU implementations will need to call
>> memory_region_notify_iommu() to inform those waiting on the notifier list,
>> whenever an IOMMU mapping is made or removed.
>>
>> Signed-off-by: David Gibson <address@hidden>
>> @@ -423,6 +425,11 @@ static inline bool memory_region_is_romd(MemoryRegion 
>> *mr)
>>   */
>>  bool memory_region_is_iommu(MemoryRegion *mr);
>>
>> +void memory_region_notify_iommu(MemoryRegion *mr,
>> +                                IOMMUTLBEntry entry);
>> +void memory_region_register_iommu_notifier(MemoryRegion *mr, Notifier *n);
>> +void memory_region_unregister_iommu_notifier(Notifier *n);
> 
> These all need doc comments.

David, can you provide them?  (If not as a patch, just an inline reply
to this email will do).

Paolo