[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid |
Date: |
Fri, 24 May 2013 14:38:36 +0100 |
On 24 May 2013 14:33, Paolo Bonzini <address@hidden> wrote:
> Il 24/05/2013 15:27, Peter Maydell ha scritto:
>> On 24 May 2013 13:58, Paolo Bonzini <address@hidden> wrote:
>>> If it's okay
>>> for you, I'll send a pull request up to "memory: clean up phys_page_find"
>>> and go on with the next series.
>>
>> That's fine with me, but please don't forget to fix up
>> the doc comment for memory_region_find() (see comments on
>> patch 6/30). You can do that in a patch in the next series,
>> though, I guess.
>
> What about this:
>
> /**
> * memory_region_find: translate an address/size relative to a
> * MemoryRegion into a #MemoryRegionSection.
> *
> * Locates the first #MemoryRegion within @mr that overlaps the range
> * given by @addr and @size.
> *
> * Returns a #MemoryRegionSection that describes a contiguous overlap.
> * It will have the following characteristics:
> * address@hidden = 0 iff no overlap was found
> * address@hidden is non-%NULL iff an overlap was found
> *
> * Remember that in the return value the @offset_within_region is
> * relative to the returned region (in the address@hidden field), not to the
> * @mr argument.
> *
> * Similarly, the address@hidden is relative to the
> * address space that contains both regions, the passed and the
> * returned one. However, in the special case where the @mr argument
> * has no parent (and thus is the root of the address space), the
> * following will hold:
> * address@hidden >= @addr
> * address@hidden + address@hidden <= @addr + @size
> *
> * @mr: a MemoryRegion within which @addr is a relative address
> * @addr: start of the area within @as to be searched
> * @size: size of the area to be searched
> */
Yes, that looks OK to me.
thanks
-- PMM
- Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid, (continued)
- Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid, Paolo Bonzini, 2013/05/24
- Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid, Peter Maydell, 2013/05/24
- Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid, Paolo Bonzini, 2013/05/24
- Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid, Peter Maydell, 2013/05/24
- Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid, Paolo Bonzini, 2013/05/24
- Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid, David Gibson, 2013/05/24
- Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid, Peter Maydell, 2013/05/25
- Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid, David Gibson, 2013/05/26
[Qemu-devel] [PATCH 16/30] memory: clean up phys_page_find, Paolo Bonzini, 2013/05/21
[Qemu-devel] [PATCH 18/30] memory: add return value to address_space_rw/read/write, Paolo Bonzini, 2013/05/21
[Qemu-devel] [PATCH 17/30] memory: add address_space_translate, Paolo Bonzini, 2013/05/21