Re: [Qemu-devel] [PATCH] boot: fix path pattern of scsi device

[Laszlo Ersek]

On 05/28/13 10:06, Paolo Bonzini wrote:
> Il 28/05/2013 09:40, Amos Kong ha scritto:
>> bootindex parameter of scsi device doesn't work, it causes
>> by wrong pattern in seabios.
>>
>> qemu passes the following firmware dev_path to seabios:
>>  
>> /address@hidden/address@hidden/virtio-scsi-device/address@hidden/address@hidden,0
> 
> No, this is another unexpected change due to the virtio refactoring in
> QEMU.  The right fix is in QEMU, by adding a get_fw_dev_path
> implementation in hw/virtio/virtio-bus.c.
> 
> We fixed it already for migration paths, it should be easy to do the
> same for this.
> 
> Please Cc address@hidden when sending the QEMU patch.
> 
> Thanks,
> 
> Paolo

Ahhh. I was super confused by this patch initially.

Amos, when posting a patch to both lists, please add the project name to
the bracketed bag-of-tags in the subject, like

[SeaBIOS PATCH] boot: fix path pattern of scsi device

I saw this message first on qemu-devel, and until I noticed "src/boot.c"
I was kind of confused whom you want to adapt to whom, and in what
direction Paolo argues against it.

So, virtio refactoring in QEMU (care to name a commit or release?)
changed the OpenFirmware device path exported for virtio-scsi devices
under the boot order fw_cfg key. This patch intended to adapt SeaBIOS to
recognize the new OFW devpath. Under this approach I would have to
update QemuBootOrder.c in OVMF in parallel, so that it accepts both old
and new style OFW devpaths for virtio-scsi.

However Paolo says the new style OFW devpath should be fixed
(eliminated) in qemu, and consumers shouldn't notice any change in the
long term. And I won't have to change QemuBootOrder.c. Right?

Thanks!
Laszlo