[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] qemu-iotests: reduce iotests.py code duplic
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] qemu-iotests: reduce iotests.py code duplication |
Date: |
Wed, 29 May 2013 12:04:26 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 28.05.2013 um 17:11 hat Stefan Hajnoczi geschrieben:
> Tests 030 and 041 are written in Python and use the iotests.py module. Push
> common code down into iotests.py. My 'drive-backup' series takes advantage
> will take advantage of this - kwolf pointed out that earlier revisions were
> duplicating too much code.
>
> I decided to split this into a separate patch series and send it before the
> next 'drive-backup' revision.
>
> Stefan Hajnoczi (4):
> qemu-iotests: make assert_no_active_block_jobs() common
> qemu-iotests: make cancel_and_wait() common
> qemu-iotests: make compare_images() common
> qemu-iotests: make create_image() common
>
> tests/qemu-iotests/030 | 99 ++++++++---------------
> tests/qemu-iotests/041 | 181
> +++++++++++++++---------------------------
> tests/qemu-iotests/iotests.py | 38 +++++++++
> 3 files changed, 135 insertions(+), 183 deletions(-)
Looks correct, but I had a question/comment about patch 2.
Kevin
- [Qemu-devel] [PATCH 0/4] qemu-iotests: reduce iotests.py code duplication, Stefan Hajnoczi, 2013/05/28
- [Qemu-devel] [PATCH 2/4] qemu-iotests: make cancel_and_wait() common, Stefan Hajnoczi, 2013/05/28
- [Qemu-devel] [PATCH 3/4] qemu-iotests: make compare_images() common, Stefan Hajnoczi, 2013/05/28
- [Qemu-devel] [PATCH 1/4] qemu-iotests: make assert_no_active_block_jobs() common, Stefan Hajnoczi, 2013/05/28
- [Qemu-devel] [PATCH 4/4] qemu-iotests: make create_image() common, Stefan Hajnoczi, 2013/05/28
- Re: [Qemu-devel] [PATCH 0/4] qemu-iotests: reduce iotests.py code duplication, Fam Zheng, 2013/05/29
- Re: [Qemu-devel] [PATCH 0/4] qemu-iotests: reduce iotests.py code duplication,
Kevin Wolf <=
- Re: [Qemu-devel] [PATCH 0/4] qemu-iotests: reduce iotests.py code duplication, Kevin Wolf, 2013/05/29