[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 04/16] qemu-io: Handle cvtnum() errors in 'alloc'
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH v2 04/16] qemu-io: Handle cvtnum() errors in 'alloc' |
Date: |
Wed, 5 Jun 2013 14:19:29 +0200 |
Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
qemu-io.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/qemu-io.c b/qemu-io.c
index 8a719a8..b4f56fc 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -1596,7 +1596,10 @@ static int alloc_f(int argc, char **argv)
int ret;
offset = cvtnum(argv[1]);
- if (offset & 0x1ff) {
+ if (offset < 0) {
+ printf("non-numeric offset argument -- %s\n", argv[1]);
+ return 0;
+ } else if (offset & 0x1ff) {
printf("offset %" PRId64 " is not sector aligned\n",
offset);
return 0;
@@ -1604,6 +1607,10 @@ static int alloc_f(int argc, char **argv)
if (argc == 3) {
nb_sectors = cvtnum(argv[2]);
+ if (nb_sectors < 0) {
+ printf("non-numeric length argument -- %s\n", argv[2]);
+ return 0;
+ }
} else {
nb_sectors = 1;
}
--
1.8.1.4
- [Qemu-devel] [PATCH v2 00/16] Make qemu-io commands available in the monitor, Kevin Wolf, 2013/06/05
- [Qemu-devel] [PATCH v2 01/16] qemu-io: Remove unused args_command, Kevin Wolf, 2013/06/05
- [Qemu-devel] [PATCH v2 02/16] cutils: Support 'P' and 'E' suffixes in strtosz(), Kevin Wolf, 2013/06/05
- [Qemu-devel] [PATCH v2 04/16] qemu-io: Handle cvtnum() errors in 'alloc',
Kevin Wolf <=
- [Qemu-devel] [PATCH v2 03/16] qemu-io: Make cvtnum() a wrapper around strtosz_suffix(), Kevin Wolf, 2013/06/05
- [Qemu-devel] [PATCH v2 06/16] qemu-io: Split off commands to qemu-io-cmds.c, Kevin Wolf, 2013/06/05
- [Qemu-devel] [PATCH v2 10/16] qemu-io: Move qemu_strsep() to cutils.c, Kevin Wolf, 2013/06/05
- [Qemu-devel] [PATCH v2 12/16] qemu-io: Move command_loop() and friends, Kevin Wolf, 2013/06/05
- [Qemu-devel] [PATCH v2 11/16] qemu-io: Move functions for registering and running commands, Kevin Wolf, 2013/06/05
- [Qemu-devel] [PATCH v2 13/16] qemu-io: Move remaining helpers from cmd.c, Kevin Wolf, 2013/06/05
- [Qemu-devel] [PATCH v2 15/16] qemu-io: Use the qemu version for -V, Kevin Wolf, 2013/06/05
- [Qemu-devel] [PATCH v2 14/16] qemu-io: Interface cleanup, Kevin Wolf, 2013/06/05
- [Qemu-devel] [PATCH v2 16/16] Make qemu-io commands available in HMP, Kevin Wolf, 2013/06/05