[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] xilinx_axienet: Fix bit mask code
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] xilinx_axienet: Fix bit mask code |
|
Date: |
Sun, 9 Jun 2013 22:22:09 +0100 |
On 9 June 2013 21:56, Stefan Weil <address@hidden> wrote:
> diff --git a/hw/net/xilinx_axienet.c b/hw/net/xilinx_axienet.c
> index 8989e95..2ca1511 100644
> --- a/hw/net/xilinx_axienet.c
> +++ b/hw/net/xilinx_axienet.c
> @@ -575,7 +575,7 @@ static void enet_write(void *opaque, hwaddr addr,
> break;
>
> case R_MC:
> - value &= ((1 < 7) - 1);
> + value &= ((1 << 7) - 1);
Whoops. No objection to this patch as it stands; another option
would be
value = extract32(value, 0, 7);
thanks
-- PMM