[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qom-cpu 08/59] cpus: Simplify qmp_inject_nmi()
From: |
li guang |
Subject: |
Re: [Qemu-devel] [PATCH qom-cpu 08/59] cpus: Simplify qmp_inject_nmi() |
Date: |
Mon, 10 Jun 2013 10:19:12 +0800 |
Reviewed-by: liguang <address@hidden>
在 2013-06-09日的 21:12 +0200,Andreas Färber写道:
> Use new qemu_for_each_cpu().
>
> Signed-off-by: Andreas Färber <address@hidden>
> ---
> cpus.c | 24 +++++++++++++++---------
> 1 file changed, 15 insertions(+), 9 deletions(-)
>
> diff --git a/cpus.c b/cpus.c
> index 24ee974..1975c5c 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -1331,18 +1331,24 @@ exit:
> fclose(f);
> }
>
> -void qmp_inject_nmi(Error **errp)
> -{
> #if defined(TARGET_I386)
> - CPUArchState *env;
> +static void qmp_inject_one_nmi(CPUState *cs, void *data)
> +{
> + X86CPU *cpu = X86_CPU(cs);
> + CPUX86State *env = &cpu->env;
>
> - for (env = first_cpu; env != NULL; env = env->next_cpu) {
> - if (!env->apic_state) {
> - cpu_interrupt(CPU(x86_env_get_cpu(env)), CPU_INTERRUPT_NMI);
> - } else {
> - apic_deliver_nmi(env->apic_state);
> - }
> + if (!env->apic_state) {
> + cpu_interrupt(cs, CPU_INTERRUPT_NMI);
> + } else {
> + apic_deliver_nmi(env->apic_state);
> }
> +}
> +#endif
> +
> +void qmp_inject_nmi(Error **errp)
> +{
> +#if defined(TARGET_I386)
> + qemu_for_each_cpu(qmp_inject_one_nmi, NULL);
> #else
> error_set(errp, QERR_UNSUPPORTED);
> #endif
- [Qemu-devel] [PATCH qom-cpu 02/59] kvm: Change cpu_synchronize_state() argument to CPUState, (continued)
- [Qemu-devel] [PATCH qom-cpu 02/59] kvm: Change cpu_synchronize_state() argument to CPUState, Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu 05/59] cpus: Simplify pause_all_vcpus(), Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu 06/59] cpus: Simplify resume_all_vcpus(), Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu 07/59] cpus: Simplify set_numa_modes(), Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu 08/59] cpus: Simplify qmp_inject_nmi(), Andreas Färber, 2013/06/09
- Re: [Qemu-devel] [PATCH qom-cpu 08/59] cpus: Simplify qmp_inject_nmi(),
li guang <=
- [Qemu-devel] [PATCH qom-cpu 09/59] cpus: Simplify hw_error(), Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu 10/59] cpus: Simplify qemu_tcg_wait_io_event() and qemu_tcg_cpu_thread_fn(), Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu 11/59] monitor: Simplify do_inject_mce(), Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu 12/59] gdbstub: Simplify find_cpu(), Andreas Färber, 2013/06/09