Re: [Qemu-devel] [PATCH qom-cpu 00/59] QOM CPUState, part 10: CPU loops

[Stefano Stabellini]

On Sun, 9 Jun 2013, Andreas Färber wrote:
> Hello,
> 
> Based on my guest-memory-dump cleanup patches, this large series changes
> cpu_single_env, first_cpu, next_cpu and thread_env to CPUState.
> 
> As a prerequisite, most open-coded CPU loops are replaced by either
> qemu_for_each_cpu() or qemu_get_cpu(). Individual review appreciated!
> 
> qemu_init_vcpu() is converted to CPUState and moved away from targets.
> 
> cpu_unassigned_access(), cpu_dump_state() and cpu_dump_statistics() are turned
> into CPUClass methods. exec/hwaddr.h is modified to allows its use in 
> qom/cpu.h.
> 
> Available for testing at:
> git://github.com/afaerber/qemu-cpu.git qom-cpu-10.v1
> https://github.com/afaerber/qemu-cpu/commits/qom-cpu-10.v1
> 
> Regards,
> Andreas
> 
> Cc: Anthony Liguori <address@hidden>
> Cc: Blue Swirl <address@hidden>
> Cc: Aurélien Jarno <address@hidden>
> Cc: Paolo Bonzini <address@hidden> (cpu_unassigned_access)
> Cc: Stefano Stabellini <address@hidden> (dummy CPU thread changes)
> Cc: Peter Maydell <address@hidden> (hwaddr)
> 
> Andreas Färber (59):
>   kvm: Change kvm_cpu_synchronize_state() argument to CPUState
>   kvm: Change cpu_synchronize_state() argument to CPUState
>   cpus: Simplify cpu_synchronize_all_post_reset()
>   cpus: Simplify cpu_synchronize_all_post_init()
>   cpus: Simplify pause_all_vcpus()
>   cpus: Simplify resume_all_vcpus()
>   cpus: Simplify set_numa_modes()
>   cpus: Simplify qmp_inject_nmi()
>   cpus: Simplify hw_error()
>   cpus: Simplify qemu_tcg_wait_io_event() and qemu_tcg_cpu_thread_fn()
>   monitor: Simplify do_inject_mce()
>   gdbstub: Simplify find_cpu()
>   cpu: Change cpu_exit() argument to CPUState
>   cpus: Change cpu_thread_is_idle() argument to CPUState
>   cpus: Change qemu_kvm_wait_io_event() argument to CPUState
>   kvm: Change kvm_set_signal_mask() argument to CPUState
>   cpus: Change qemu_kvm_init_cpu_signals() argument to CPUState
>   cpu: Turn cpu_dump_{state,statistics}() into CPUState hooks
>   kvm: Change kvm_handle_internal_error() argument to CPUState
>   kvm: Change kvm_cpu_exec() argument to CPUState
>   gdbstub: Set gdb_set_stop_cpu() argument to CPUState
>   cpus: Change cpu_handle_guest_debug() argument to CPUState
>   cpus: Change qemu_kvm_start_vcpu() argument to CPUState
>   cpus: Change qemu_dummy_start_vcpu() argument to CPUState
>   cpu: Change qemu_init_vcpu() argument to CPUState
>   hwaddr: Make hwaddr type usable beyond softmmu
>   cpu: Turn cpu_unassigned_access() into a CPUState hook

    ^
    git-bisect tells me that this commit breaks Xen HVM support in QEMU