|
From: | Frederic Konrad |
Subject: | Re: [Qemu-devel] [RFT PATCH v1 12/30] virtio/virtio-pci: QOM casting sweep |
Date: | Tue, 11 Jun 2013 09:09:29 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Hi, On 11/06/2013 08:49, address@hidden wrote:
From: Peter Crosthwaite <address@hidden> Use standard QOM cast macro. Remove usages of container_of() and direct -> style upcasting. Signed-off-by: Peter Crosthwaite <address@hidden>
[...]
static inline VirtIOPCIProxy *to_virtio_pci_proxy(DeviceState *d) { - return container_of(d, VirtIOPCIProxy, pci_dev.qdev); + return VIRTIO_PCI(d); }
Maybe you can replace each to_virtio_pci_proxy directly with VIRTIO_PCI?
/* DeviceState to VirtIOPCIProxy. Note: used on datapath,@@ -106,7 +106,7 @@ static inline VirtIOPCIProxy *to_virtio_pci_proxy(DeviceState *d) */ static inline VirtIOPCIProxy *to_virtio_pci_proxy_fast(DeviceState *d) { - return container_of(d, VirtIOPCIProxy, pci_dev.qdev); + return VIRTIO_PCI(d); }static void virtio_pci_notify(DeviceState *d, uint16_t vector)
[Prev in Thread] | Current Thread | [Next in Thread] |