[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 15/16] boot-order-test: Support fw_cfg in I/O
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v3 15/16] boot-order-test: Support fw_cfg in I/O space |
Date: |
Fri, 14 Jun 2013 16:04:36 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 |
Am 14.06.2013 15:53, schrieb Anthony Liguori:
> Markus Armbruster <address@hidden> writes:
>
>> Next commit needs it.
>>
>> Cc: Blue Swirl <address@hidden>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> tests/boot-order-test.c | 24 ++++++++++++++++--------
>> 1 file changed, 16 insertions(+), 8 deletions(-)
>>
>> diff --git a/tests/boot-order-test.c b/tests/boot-order-test.c
>> index 7b1edc1..d1d99f8 100644
>> --- a/tests/boot-order-test.c
>> +++ b/tests/boot-order-test.c
>> @@ -133,23 +133,31 @@ static void test_prep_boot_order(void)
>> test_boot_orders("prep", read_boot_order_prep, test_cases_prep);
>> }
>>
>> -static void read_fw_cfg(uint64_t cfg_addr, uint16_t cmd,
>> +static void read_fw_cfg(uint64_t cfg_addr, bool addr_is_io, uint16_t cmd,
>> void *buf, size_t len)
>
> I missed it earlier, but you can use libqos/fw_cfg.h for this.
Agree, but that didn't exist at the time. :-)
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH v3 12/16] boot-order-test: Code motion for better readability, (continued)
- [Qemu-devel] [PATCH v3 12/16] boot-order-test: Code motion for better readability, Markus Armbruster, 2013/06/14
- [Qemu-devel] [PATCH v3 06/16] doc: Drop ref to Bochs from -no-fd-bootchk documentation, Markus Armbruster, 2013/06/14
- [Qemu-devel] [PATCH v3 14/16] boot-order-test: Add tests for Sun4m, Markus Armbruster, 2013/06/14
- [Qemu-devel] [PATCH v3 11/16] boot-order-test: Better separate target-specific and generic parts, Markus Armbruster, 2013/06/14
- [Qemu-devel] [PATCH v3 09/16] boot-order-test: Add tests for PowerMacs, Markus Armbruster, 2013/06/14
- [Qemu-devel] [PATCH v3 15/16] boot-order-test: Support fw_cfg in I/O space, Markus Armbruster, 2013/06/14
- [Qemu-devel] [PATCH v3 16/16] boot-order-test: Add tests for Sun4u, Markus Armbruster, 2013/06/14
- Re: [Qemu-devel] [PATCH v3 00/16] -boot and -no-fd-bootchk fixes, Anthony Liguori, 2013/06/21