[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qom-cpu 25/59] cpu: Change qemu_init_vcpu() argu
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH qom-cpu 25/59] cpu: Change qemu_init_vcpu() argument to CPUState |
Date: |
Sun, 16 Jun 2013 10:27:29 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 |
嗨,
Am 11.06.2013 04:39, schrieb li guang:
> 在 2013-06-09日的 21:12 +0200,Andreas Färber写道:
>> This allows to move the call to CPUState's realizefn.
>> Therefore move the stub into libqemustub.a.
>>
>> Signed-off-by: Andreas Färber <address@hidden>
> [...]
>> diff --git a/target-arm/cpu.c b/target-arm/cpu.c
>> index a40290c..88ee61b 100644
>> --- a/target-arm/cpu.c
>> +++ b/target-arm/cpu.c
>> @@ -205,7 +205,6 @@ static void arm_cpu_realizefn(DeviceState *dev, Error
>> **errp)
>> arm_cpu_register_gdb_regs_for_features(cpu);
>>
>> cpu_reset(CPU(cpu));
>
> can this and following 'cpu_reset' also be moved to
> 'cpu_common_realizefn' like 'qemu_init_vcpu'?
I have a branch qom-cpu-reset that tried this. However the culprit was
that alpha reset was broken and we have not yet fully fixed it.
I.e., through the memset() up to "breakpoints" some pointers would get
overridden, so calling it is not a good idea at the moment. But if you
have some spare time and an alpha guest... ;)
I chose to leave the cpu_index logging line in place until I can move it
together with log_cpu_state() (depended on patch 18/59), for which I
have a patch on qom-cpu-11 branch. :)
Cheers,
Andreas
>> - qemu_init_vcpu(env);
>>
>> acc->parent_realize(dev, errp);
>> }
[snip]
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH qom-cpu 19/59] kvm: Change kvm_handle_internal_error() argument to CPUState, (continued)
- [Qemu-devel] [PATCH qom-cpu 19/59] kvm: Change kvm_handle_internal_error() argument to CPUState, Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu 20/59] kvm: Change kvm_cpu_exec() argument to CPUState, Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu 21/59] gdbstub: Set gdb_set_stop_cpu() argument to CPUState, Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu 22/59] cpus: Change cpu_handle_guest_debug() argument to CPUState, Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu 23/59] cpus: Change qemu_kvm_start_vcpu() argument to CPUState, Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu 24/59] cpus: Change qemu_dummy_start_vcpu() argument to CPUState, Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu 26/59] hwaddr: Make hwaddr type usable beyond softmmu, Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu 18/59] cpu: Turn cpu_dump_{state, statistics}() into CPUState hooks, Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu 25/59] cpu: Change qemu_init_vcpu() argument to CPUState, Andreas Färber, 2013/06/09
[Qemu-devel] [PATCH qom-cpu 27/59] cpu: Turn cpu_unassigned_access() into a CPUState hook, Andreas Färber, 2013/06/09
[Qemu-devel] [PATCH qom-cpu 29/59] cputlb: Simplify cpu_tlb_reset_dirty_all(), Andreas Färber, 2013/06/09
[Qemu-devel] [PATCH qom-cpu 30/59] exec: Simplify tcg_commit(), Andreas Färber, 2013/06/09
[Qemu-devel] [PATCH qom-cpu 31/59] monitor: Simplify do_info_numa(), Andreas Färber, 2013/06/09