[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 3/5] block/nand: QOM casting sweep
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v1 3/5] block/nand: QOM casting sweep |
Date: |
Wed, 19 Jun 2013 12:52:08 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 |
Am 18.06.2013 13:10, schrieb address@hidden:
> From: Peter Crosthwaite <address@hidden>
>
> Define and use standard QOM cast macro. Remove usages of DO_UPCAST and
> direct -> style casting.
>
> Cc: address@hidden
>
> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
>
> hw/block/nand.c | 25 ++++++++++++++++---------
> 1 file changed, 16 insertions(+), 9 deletions(-)
>
> diff --git a/hw/block/nand.c b/hw/block/nand.c
> index de0a022..d2469f5 100644
> --- a/hw/block/nand.c
> +++ b/hw/block/nand.c
[...]
> @@ -319,14 +324,14 @@ static void nand_command(NANDFlashState *s)
>
> static void nand_pre_save(void *opaque)
> {
> - NANDFlashState *s = opaque;
> + NANDFlashState *s = NAND(opaque);
>
> s->ioaddr_vmstate = s->ioaddr - s->io;
> }
>
> static int nand_post_load(void *opaque, int version_id)
> {
> - NANDFlashState *s = opaque;
> + NANDFlashState *s = NAND(opaque);
>
> if (s->ioaddr_vmstate > sizeof(s->io)) {
> return -EINVAL;
[snip]
These two are not strictly necessary, but either way:
Reviewed-by: Andreas Färber <address@hidden>
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH v1 0/5] Nand Cleanup, peter . crosthwaite, 2013/06/18
- [Qemu-devel] [PATCH v1 2/5] block/nand: Formatting sweep, peter . crosthwaite, 2013/06/18
- [Qemu-devel] [PATCH v1 3/5] block/nand: QOM casting sweep, peter . crosthwaite, 2013/06/18
- Re: [Qemu-devel] [PATCH v1 3/5] block/nand: QOM casting sweep,
Andreas Färber <=
- [Qemu-devel] [PATCH v1 4/5] block/nand: Convert Sysbus::init to Device::realize, peter . crosthwaite, 2013/06/18
- [Qemu-devel] [PATCH v1 5/5] nand: Don't inherit from Sysbus, peter . crosthwaite, 2013/06/18
- Re: [Qemu-devel] [PATCH v1 0/5] Nand Cleanup, Peter Maydell, 2013/06/25