[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] iSCSI fix crash when using virtio and libiscsi
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] iSCSI fix crash when using virtio and libiscsi |
Date: |
Fri, 21 Jun 2013 09:38:18 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
Il 21/06/2013 04:32, Ronnie Sahlberg ha scritto:
> Stefan, List
>
> Please find a patch that fixes the crashes for using virtio with libiscsi.
> The problem was that block/iscsi.c always assumed we got a plain buffer to
> read data into, and when we got an iovector array instead we would overwrite
> pointers with garbage and crash.
>
> Since we can get iovectors for the write case as well I have added a fix for
> when the guest is writing data to the target to handle the iovector case as
> well.
>
>
> The new calls added are not protected with (LIBISCSI_FEATURE_IOVECTOR) checks
> since anyone building a new/current version of qemu should probably also build
> against a current libiscsi.
Not necessarily, you may build against an older libiscsi from the distro.
Can you resubmit with the checks intact?
Paolo
> I will send patches later to remove the current (LIBISCSI_FEATURE_IOVECTOR)
> checks in the rest of the file.