[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 23/23] vmdk: refuse to open higher version than supp
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 23/23] vmdk: refuse to open higher version than supported |
Date: |
Mon, 24 Jun 2013 11:10:35 +0200 |
From: Fam Zheng <address@hidden>
Refuse to open higher version for safety.
Although we try to be compatible with published VMDK spec, VMware has
newer version from ESXi 5.1 exported OVF/OVA, which we have no knowledge
what's changed in it. And it is very likely to have more new versions in
the future, so it's not safe to open them blindly.
Signed-off-by: Fam Zheng <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
block/vmdk.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/block/vmdk.c b/block/vmdk.c
index 65ae011..975e1d4 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -561,6 +561,15 @@ static int vmdk_open_vmdk4(BlockDriverState *bs,
header = footer.header;
}
+ if (le32_to_cpu(header.version) >= 3) {
+ char buf[64];
+ snprintf(buf, sizeof(buf), "VMDK version %d",
+ le32_to_cpu(header.version));
+ qerror_report(QERR_UNKNOWN_BLOCK_FORMAT_FEATURE,
+ bs->device_name, "vmdk", buf);
+ return -ENOTSUP;
+ }
+
l1_entry_sectors = le32_to_cpu(header.num_gtes_per_gte)
* le64_to_cpu(header.granularity);
if (l1_entry_sectors == 0) {
--
1.8.1.4
- [Qemu-devel] [PATCH 11/23] ide: Convert SET FEATURES to ide_cmd_table handler, (continued)
- [Qemu-devel] [PATCH 11/23] ide: Convert SET FEATURES to ide_cmd_table handler, Stefan Hajnoczi, 2013/06/24
- [Qemu-devel] [PATCH 12/23] ide: Convert FLUSH CACHE to ide_cmd_table handler, Stefan Hajnoczi, 2013/06/24
- [Qemu-devel] [PATCH 13/23] ide: Convert SEEK to ide_cmd_table handler, Stefan Hajnoczi, 2013/06/24
- [Qemu-devel] [PATCH 14/23] ide: Convert ATAPI commands to ide_cmd_table handler, Stefan Hajnoczi, 2013/06/24
- [Qemu-devel] [PATCH 15/23] ide: Convert CF-ATA commands to ide_cmd_table handler, Stefan Hajnoczi, 2013/06/24
- [Qemu-devel] [PATCH 16/23] ide: Convert SMART commands to ide_cmd_table handler, Stefan Hajnoczi, 2013/06/24
- [Qemu-devel] [PATCH 17/23] ide: Clean up ide_exec_cmd(), Stefan Hajnoczi, 2013/06/24
- [Qemu-devel] [PATCH 18/23] Revert "block: Disable driver-specific options for 1.5", Stefan Hajnoczi, 2013/06/24
- [Qemu-devel] [PATCH 19/23] qcow2: Add refcount update reason to all callers, Stefan Hajnoczi, 2013/06/24
- [Qemu-devel] [PATCH 20/23] qcow2: Options to enable discard for freed clusters, Stefan Hajnoczi, 2013/06/24
- [Qemu-devel] [PATCH 23/23] vmdk: refuse to open higher version than supported,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 21/23] qcow2: Batch discards, Stefan Hajnoczi, 2013/06/24
- [Qemu-devel] [PATCH 22/23] block: Always enable discard on the protocol level, Stefan Hajnoczi, 2013/06/24