qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] cmd646: fix build when DEBUG_IDE is enabled.


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH] cmd646: fix build when DEBUG_IDE is enabled.
Date: Fri, 28 Jun 2013 15:52:13 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6

Am 28.06.2013 15:43, schrieb Mark Cave-Ayland:
> Make sure we use the correct TARGET/PRI macros in the debug statements.
> 
> Signed-off-by: Mark Cave-Ayland <address@hidden>
> CC: Kevin Wolf <address@hidden>
> ---
>  hw/ide/cmd646.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c
> index a73eb9a..9916701 100644
> --- a/hw/ide/cmd646.c
> +++ b/hw/ide/cmd646.c
> @@ -154,7 +154,7 @@ static uint64_t bmdma_read(void *opaque, hwaddr addr,
>          break;
>      }
>  #ifdef DEBUG_IDE
> -    printf("bmdma: readb 0x%02x : 0x%02x\n", addr, val);
> +    printf("bmdma: readb " TARGET_FMT_plx " : 0x%02x\n", addr, val);

To remain output-compatible you could use "0x%02" HWADDR_PRIx.
While touching it, "0x%02" PRIx32 would be consistent for uint32_t val.

Andreas

>  #endif
>      return val;
>  }
> @@ -170,7 +170,7 @@ static void bmdma_write(void *opaque, hwaddr addr,
>      }
>  
>  #ifdef DEBUG_IDE
> -    printf("bmdma: writeb 0x%02x : 0x%02x\n", addr, val);
> +    printf("bmdma: writeb " TARGET_FMT_plx " : 0x%" PRIx64 "\n", addr, val);
>  #endif
>      switch(addr & 3) {
>      case 0:
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]