[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-mips: fix mipsdsp_trunc16_sat16_round
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-mips: fix mipsdsp_trunc16_sat16_round |
|
Date: |
Fri, 28 Jun 2013 10:40:29 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130612 Thunderbird/17.0.6 |
On 06/27/2013 02:48 PM, Petar Jovanovic wrote:
>> This doesn't look right either, as it doesn't properly check for overflow of
>> negative values.
>
> What overflow of negative values?
> Can you please list the values for which the result would not be correct?
Hmm, I suppose since we're always rounding to +INF, we can't
overflow in the negative direction. The patch could use some
commentary along those lines...
r~