[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 07/17] PPC: dbdma: Allow new commands in RUN state
From: |
Alexander Graf |
Subject: |
[Qemu-devel] [PATCH 07/17] PPC: dbdma: Allow new commands in RUN state |
Date: |
Mon, 1 Jul 2013 02:13:32 +0200 |
The DBDMA controller can not change its command stream while it's
actively streaming data, true. But the fact that it's in RUN state
doesn't actually indicate anything. It could just as well be in
WAIT while in RUN. And then it's legal to change commands.
This fixes a real world issue I've encountered with Mac OS X.
Signed-off-by: Alexander Graf <address@hidden>
---
hw/misc/macio/mac_dbdma.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/misc/macio/mac_dbdma.c b/hw/misc/macio/mac_dbdma.c
index 908a123..ab32957 100644
--- a/hw/misc/macio/mac_dbdma.c
+++ b/hw/misc/macio/mac_dbdma.c
@@ -725,11 +725,11 @@ static void dbdma_write(void *opaque, hwaddr addr,
DBDMA_DPRINTF("channel 0x%x reg 0x%x\n",
(uint32_t)addr >> DBDMA_CHANNEL_SHIFT, reg);
- /* cmdptr cannot be modified if channel is RUN or ACTIVE */
+ /* cmdptr cannot be modified if channel is ACTIVE */
- if (reg == DBDMA_CMDPTR_LO &&
- (ch->regs[DBDMA_STATUS] & (RUN | ACTIVE)))
+ if (reg == DBDMA_CMDPTR_LO && (ch->regs[DBDMA_STATUS] & ACTIVE)) {
return;
+ }
ch->regs[reg] = value;
--
1.8.1.4
- [Qemu-devel] [PATCH 00/17] PPC: Mac OS X guest bringup v2, Alexander Graf, 2013/06/30
- [Qemu-devel] [PATCH 06/17] PPC: dbdma: Fix debug print, Alexander Graf, 2013/06/30
- [Qemu-devel] [PATCH 01/17] PPC: Mac: Fix guest exported tbfreq values, Alexander Graf, 2013/06/30
- [Qemu-devel] [PATCH 03/17] PPC: Macio: Replace tabs with spaces, Alexander Graf, 2013/06/30
- [Qemu-devel] [PATCH 07/17] PPC: dbdma: Allow new commands in RUN state,
Alexander Graf <=
- [Qemu-devel] [PATCH 05/17] PPC: Mac: Add debug prints in macio and dbdma code, Alexander Graf, 2013/06/30
- [Qemu-devel] [PATCH 04/17] PPC: dbdma: Replace tabs with spaces, Alexander Graf, 2013/06/30
- [Qemu-devel] [PATCH 09/17] PPC: dbdma: Introduce kick function, Alexander Graf, 2013/06/30
- [Qemu-devel] [PATCH 12/17] PPC: dbdma: Move processing to io, Alexander Graf, 2013/06/30
- [Qemu-devel] [PATCH 02/17] PPC: g3beige: Move secondary IDE bus to mac-io, Alexander Graf, 2013/06/30
- [Qemu-devel] [PATCH 10/17] PPC: dbdma: Move static bh variable to device struct, Alexander Graf, 2013/06/30
- [Qemu-devel] [PATCH 15/17] PPC: Add timer handler for newworld mac-io, Alexander Graf, 2013/06/30
- [Qemu-devel] [PATCH 11/17] PPC: dbdma: macio: Add DMA callback, Alexander Graf, 2013/06/30
- [Qemu-devel] [PATCH 17/17] PPC: dbdma: Support more multi-issue DMA requests, Alexander Graf, 2013/06/30
- [Qemu-devel] [PATCH 13/17] PPC: dbdma: Wait for DMA until we have data, Alexander Graf, 2013/06/30